Update HIP target handling using alias#2099
Conversation
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_22 ran successfully. |
ndgrigorian
left a comment
There was a problem hiding this comment.
This LGTM overall
After this and the CUDA architecture update are merged, I think allowing setting CUDA and HIP architecture as arguments to scripts/build_locally.py script would be convenient
76c7bab to
73e4c90
Compare
|
Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_41 ran successfully. |
|
Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_42 ran successfully. |
|
Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_45 ran successfully. |
This PR suggests simplifying
DPCTL_TARGET_HIPhandling by using target aliasesamd_gpu_<arch>and removing support foramdgcn-amd-amdhsatarget.Also updates
docsto clarify how to determine and use the correct AMD GPU architecture.