Accept NumPy arrays in advanced indexing#2128
Merged
ndgrigorian merged 5 commits intomasterfrom Aug 1, 2025
Merged
Conversation
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_79 ran successfully. |
Collaborator
|
Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_81 ran successfully. |
antonwolfy
reviewed
Jul 30, 2025
|
Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_83 ran successfully. |
antonwolfy
approved these changes
Aug 1, 2025
Collaborator
antonwolfy
left a comment
There was a problem hiding this comment.
@ndgrigorian , no more comments from me.
I run the dpnp tests with that change and they passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes allowing NumPy arrays when indexing
usm_ndarrayThis can be useful where attempting to use
usm_ndarrayin a library which generates indices with NumPy, and which expects to only handle devices implicitly through tensor operations (i.e., a library which can take an arbitrary tensor input, but generates indices withnumpy.randomand expects these indices to work on the input tensor)Both boolean and integer advanced indices can accept NumPy arrays with these changes
Closes #2053