Move accumulation functions mask_positions and cumsum_1d to tensor accumulation module#2157
Closed
sycloid wants to merge 1 commit intoIntelPython:masterfrom
Closed
Conversation
|
Can one of the admins verify this patch? |
Collaborator
…sitions and _cumsum_1d functions to _tensor_accumulations_impl Changed Python scripts accordingly, as well as CMake scripts to add implementation cpp file to the list of source files for the _tensor_accumulations_impl MODULE library. Also moved find_package(Python) to find Module.Development component before pybind11 is being activated to resolve CMake warning. Incidentally, this change also results in reduced binary size and improved compilation tiles, since accumulation kernels are not being generated in duplicates (once for _tensor_ctor module, and once for _tensor_accumulation_impl module).
07d0243 to
a2640ab
Compare
Collaborator
|
this did resolve the OS crash, as can be seen here: |
This was referenced Sep 26, 2025
Contributor
Author
|
The latest nightly build no longer exhibits the crash (see https://github.com/IntelPython/dpctl/actions/runs/18052500456), hence this change is no longer necessary. I confirmed that the test suite run on CPU passes in master built using SYCL build |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to resolve gh-2156 move definition of the
mask_positionsand_cumsum_1dfunctions to_tensor_accumulations_implChanged Python scripts accordingly, as well as CMake scripts to add implementation cpp file to the list of source files for the
_tensor_accumulations_implMODULE library.Also moved
find_package(Python)to findModule.Developmentcomponent beforepybind11is being activated to resolve CMake warning.Incidentally, this change also results in reduced binary size and improved compilation tiles, since accumulation kernels are not being generated in duplicates (once for
_tensor_ctormodule, and once for_tensor_accumulation_implmodule).This change resolves the segmentation fault for me locally using both OpenCL CPU and Level-Zero GPU devices.
Closes #2156