Iteration 2: Getting all simple code listings working#898
Draft
Joshua-Lester3 wants to merge 21 commits intoIntelliTect:mainfrom
Draft
Iteration 2: Getting all simple code listings working#898Joshua-Lester3 wants to merge 21 commits intoIntelliTect:mainfrom
Joshua-Lester3 wants to merge 21 commits intoIntelliTect:mainfrom
Conversation
- Updated appsettings.json to include TryDotNet origin configuration. - Introduced code-runner.css for styling the interactive code execution panel. - Implemented trydotnet-module.js for managing TryDotNet functionality, including session management, code execution, and error handling. - Enhanced site.js to initialize TryDotNet functionality alongside chat widget.
Co-authored-by: Kevin B <Keboo@users.noreply.github.com>
…roved immutability and simplicity
…ssentialCSharp.Web into jlester/try-net
…ectoryInfo for improved type safety
…ace TestWebHostEnvironment with Moq for IWebHostEnvironment in WebApplicationFactory
…ApplicationFactory
…ssentialCSharp.Web into jlester/try-net
…ding improvements - Load runnable listings from chapter-listings.json and build a Set of valid listings. - Implement functions to check if a listing is runnable and to strip region directives from code. - Update createScaffolding to prepend common using directives and handle user code more effectively. - Modify isCompleteProgram to recognize any class with a static Main method as complete. - Inject Run buttons only for listings present in the curated JSON, improving user experience.
Member
There was a problem hiding this comment.
A potential concern about this approach right now (without seeing the py this is generated by so maybe I am just missing something) is that listing numbers are able to change if we insert/delete/move a listing - how will this be handled without having to manually review/adjust these?
Collaborator
Author
There was a problem hiding this comment.
Oh yeah, definitely. I just did this draft to get it started, and have an easily ready diff.
As for that issue.. I'm not fully sure. First instinct is to generate the listing in the Tooling repo, though we will need to combine it with info about which one's are runnable. Any thoughts?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe your changes here.
Fixes #Issue_Number (if available)
Ensure that your pull request has followed all the steps below: