Fix destructuring signature() return value before nothing check #142
+6
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 3b60b6a, the return type of signature() was changed from `Tuple{Union{Nothing, Type}, PC}` to `Tuple{Union{Nothing, MethodInfoKey}, PC}`:(where PC = `Union{Int, BreakpointRef}`), but the check for `nothing` wasn't moved before the destructuring of the `MethodInfoKey`. This cuased the (caught) exception described intimholy/Revise.jl#1002.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #142 +/- ##
==========================================
+ Coverage 76.95% 77.14% +0.19%
==========================================
Files 6 6
Lines 1523 1536 +13
==========================================
+ Hits 1172 1185 +13
Misses 351 351 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aviatesk
approved these changes
Feb 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 3b60b6a, the return type of signature() was changed from
Tuple{Union{Nothing, Type}, PC}toTuple{Union{Nothing, MethodInfoKey}, PC}(where PC =Union{Int, BreakpointRef}), but the check fornothingwasn't moved before the destructuring of theMethodInfoKey. This caused the (caught) exception described in timholy/Revise.jl#1002.