Skip to content

Comments

Revert "Forward code coverage flags."#97

Merged
maleadt merged 1 commit intomainfrom
revert-94-tb/code_coverage
Feb 24, 2026
Merged

Revert "Forward code coverage flags."#97
maleadt merged 1 commit intomainfrom
revert-94-tb/code_coverage

Conversation

@maleadt
Copy link
Collaborator

@maleadt maleadt commented Feb 24, 2026

Reverts #94

Looking at the flag forwarding behavior of julia_cmd() as part of #96, it turns out the non-forwarding design is very much intended:

❯ julia --code-coverage=user -e 'println(Base.julia_cmd())'
`julia -C native -g1 --code-coverage=user`

~
❯ julia --code-coverage="lcov-%p.info" -e 'println(Base.julia_cmd())'
`julia -C native -g1 --code-coverage=all --code-coverage=/Users/tim/lcov-%p.info`

~
❯ julia --code-coverage="lcov.info" -e 'println(Base.julia_cmd())'
`julia -C native -g1`

i.e. there is an if isempty(coverage_file) || occursin("%p", coverage_file) check to avoid clobbering the same output file.

@maleadt maleadt merged commit 800556b into main Feb 24, 2026
23 checks passed
@maleadt maleadt deleted the revert-94-tb/code_coverage branch February 24, 2026 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant