Cleanup testing and small parts of vetting details#338
Merged
brianhelba merged 1 commit intomainfrom Feb 11, 2026
Merged
Conversation
brianhelba
force-pushed
the
test-factories
branch
from
26e596e to
bdfcfe3
Compare
Deploying bats-ai with
|
| Latest commit: |
8754161
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://20701695.bats-ai.pages.dev |
| Branch Preview URL: | https://test-factories.bats-ai.pages.dev |
brianhelba
force-pushed
the
test-factories
branch
from
bdfcfe3 to
8754161
Compare
naglepuff
approved these changes
Feb 10, 2026
Comment on lines
+5
to
+12
| @pytest.mark.parametrize( | ||
| 'url_suffix', | ||
| [ | ||
| 'configuration/is_admin/', | ||
| ], | ||
| ) | ||
| @pytest.mark.django_db | ||
| def test_auth_anonymous_deny(url_suffix: str, client: Client): |
Collaborator
There was a problem hiding this comment.
Why is this test parametrized? Is the intent to use this single test to make sure all of our endpoints that require auth are locked down correctly?
Member
Author
There was a problem hiding this comment.
Yes. If that never happens, we should just remove the parametrization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.