Open
Conversation
The firewallResource class has 2 types, only the 'server' type was included previously, adding the 'label_selector' type
Maintained the spacing
Maintained space
Added 'label_selector' FirewallResource type in Firewall.php
updated style
Author
|
@LKaemmerling would you please check it, we are still using my repository in our project for this issue |
Author
|
@LKaemmerling would you please look at this and merge the pull request |
Contributor
|
Why me? I don't have commit bit nor do I use this code? 🫣 |
Author
My bad, I mistakenly mentioned you @till |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The firewallResource class has 2 types, only the 'server' type was included previously, adding the 'label_selector' type