Skip to content

Unify INI values#3704

Draft
hansu wants to merge 15 commits intoLinuxCNC:masterfrom
hansu:unify-ini-values
Draft

Unify INI values#3704
hansu wants to merge 15 commits intoLinuxCNC:masterfrom
hansu:unify-ini-values

Conversation

@hansu
Copy link
Member

@hansu hansu commented Jan 17, 2026 •
edited
Loading

Fixes #3238 and #2335.

To be done

@hansu hansu added the 2.10-candidate would be nice to have fixed in 2.10 label Jan 17, 2026
@zz912
Copy link
Contributor

zz912 commented Jan 17, 2026 

* [ ]  Adapt [Gmoccapy - change spindle => spindle_0 in *.ini files #3488](https://github.com/LinuxCNC/linuxcnc/pull/3488)

Feel free remake (or close) #3488 how you need. Git is not my friend, so I cant help you.

#3488 also does:

  • INI file from PNCconf is more verbose in build_INI.py
  • correct MACHINE in 7_axis.ini
  • correct MACHINE in 6_axis.ini

@hansu hansu mentioned this pull request Jan 27, 2026
Closed
@hansu hansu force-pushed the unify-ini-values branch 2 times, most recently from 619faee to 0932268 Compare February 2, 2026 22:08
@andypugh
Copy link
Collaborator

andypugh commented Feb 4, 2026

update_ini is designed to be scriptable, (-d and -f flags) and I think I had a meta-script that ran it on all the sample configs.
I probably can't find it any more, but I could have a look.

@hansu hansu force-pushed the unify-ini-values branch 2 times, most recently from ef0fb47 to 9cc5bac Compare February 4, 2026 14:20
@hansu
Copy link
Member Author

hansu commented Feb 4, 2026

update_ini is designed to be scriptable, (-d and -f flags) and I think I had a meta-script that ran it on all the sample configs. I probably can't find it any more, but I could have a look.

Yes that would be helpful. I only used tested with the -d option so far.
The renaming stuff is done so far, only some parts which moves or copy some values are missing.
And a bit refactoring maybe.
Also a little bug where it generates two [KINS] sections...

@andypugh
Copy link
Collaborator

andypugh commented Feb 4, 2026

Yes that would be helpful.

Sorry, I looked and it's nowhere obvious. It might be sat in a git stash somewhere, but I think it's probably been lost.

I doubt it was anything special, I am not much of a scripting wizard.

hansu added 4 commits February 7, 2026 20:22
@hansu
update_ini: joints/axes don't need special treatment for 1.2
f0a0fa6 
partly revert  e7caf15
@hansu
update_ini: copy values from TRAJ to DISPLAY
0a0b7d4
@hansu
update_ini: improve regex for finding the DISPLAY section
d54e3ee 
Fixes the bugs
 - if there is a commented DISPLAY sections before the DISPLAY section, the comments are used instead
 - DISPLAY section must not be at the end --> empty section
@hansu
update_ini: remove no longer needed values from TRAJ
1d4850e
@hansu
Copy link
Member Author

hansu commented Feb 9, 2026

I copied now

  • [TRAJ]DEFAULT_LINEAR_VELOCITY -> [DISPLAY]DEFAULT_LINEAR_VELOCITY
  • [TRAJ]MIN_LINEAR_VELOCITY -> [DISPLAY]MIN_LINEAR_VELOCITY

The values are/will not be not used in TRAJ any more. Do you think we should delete them from TRAJ or keep them as a precaution ?

@c-morley
Copy link
Collaborator

c-morley commented Feb 9, 2026

Ate you sure they ate not used in the trajectory planner?
Iirc they are used in non trivial machines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

2.10-candidate would be nice to have fixed in 2.10

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unify INI file settings in DISPLAY section

4 participants

@hansu @zz912 @andypugh @c-morley