Draft
Conversation
ReenigneArcher
force-pushed
the
feat/implement-item-pages
branch
4 times, most recently
from
95e1869 to
8405435
Compare
ReenigneArcher
force-pushed
the
feat/implement-item-pages
branch
from
8405435 to
5faa1ac
Compare
Replace the Bootstrap carousel-based banner with a beautiful-jekyll-next style banner implementation. HTML: remove the carousel markup and add a hidden #game-big-imgs element to store artwork data attributes and a visible #game-banner-header with an .img-desc for captions. JS: stop building carousel items; instead set data-img-src-X and data-num-img on #game-big-imgs and introduce initGameBanner() which initializes the header background, prefetches images, and cycles them with a fade transition (timing/prefetch logic included). Keeps existing content rendering and preserves fallback when no artworks are present.
Replace the old search form with a centered input+button and onsubmit/onkeydown handlers to call run_search, removing the platform select. Rewrite search results rendering in item_loader.js: change grid breakpoints, fetch platform data to show cover images, platform badges (with earliest release year), and a fallback rendering when platform data fails; limit to first 60 matches and show a note. Remove code that previously populated a search_type select. Minor modal styling adjustments in image_modal.html (remove explicit text-white/btn-close-white classes and plain modal counter) to rely on default styles.
ReenigneArcher
force-pushed
the
feat/implement-item-pages
branch
2 times, most recently
from
9485039 to
a276103
Compare
Switch banner/artwork rendering to reuse the existing page header instead of dedicated banner elements. Renamed/repurposed the hidden container from #game-big-imgs to #header-big-imgs, removed the standalone #game-banner-header markup, and injects .img-desc into header.header-section .intro-header as needed. Updated initGameBanner to target the intro-header.big-img, prepend transition nodes there, and guard against missing elements. Also removed an inline max-width on the cover image and cleaned up related markup so the banner integrates with the site's header layout.
Replace many dict() calls with literal {} notation for consistency and readability (auth headers, youtube headers, request_dict, full_dict, buckets, etc.). Add test_count tracking and a --test_limit CLI argument to limit items collected when --test_mode is enabled; the loop now stops when test_count >= test_limit. Minor help text and messaging tweaks for test mode and clearer dict initializations; small change to how empty appended items are created ({} instead of dict()).
ReenigneArcher
force-pushed
the
feat/implement-item-pages
branch
3 times, most recently
from
4356f42 to
56d527c
Compare
When rendering a game, hide the page H1 text via visibility (keeps layout space) if a banner image is present and initialize the banner display. If no banner is available, hide the entire page header (display: none) to avoid an empty header area. Also remove the global CSS rule that previously hid H1s in browse/games.html so the JS can control header visibility instead.
ReenigneArcher
force-pushed
the
feat/implement-item-pages
branch
3 times, most recently
from
d0c4c0f to
88d06fa
Compare
For search results, fetch full game JSON for the first 60 matches (using Promise.all) and gracefully handle fetch failures by falling back to partial data. Normalize IGDB cover URLs to use a larger cover size (t_cover_big) and ensure absolute URLs, increase cover/placeholder height from 180px to 240px, and improve name layout with two-line clamping and bolder text. Also keep the same behavior when platform data can't be loaded by still fetching game details.
ReenigneArcher
force-pushed
the
feat/implement-item-pages
branch
from
88d06fa to
93175be
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements item pages.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage