Skip to content

fix(projects): main urls should not use project base path #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ReenigneArcher merged 1 commit into from
Jan 7, 2025
Merged

fix(projects): main urls should not use project base path #196

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion .github/workflows/jekyll-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,16 @@ on:
required: false
default: 'master'
type: string
base_url:
description: |
Base URL of the site. With default option, the root will come from LizardByte.github.io (app.lizardbyte.dev).
This is useful to re-use the theme config and many assets from that site; but requires you to prefix other
assets with `/<RepoName>` (e.g. `/MyRepo/assets/img/my-image.png`).

If this is set to `_auto`, the workflow will determine this value automatically.
required: false
default: ''
type: string
secrets:
GH_BOT_EMAIL:
description: 'Email address of the bot account'
Expand Down Expand Up @@ -173,7 +183,11 @@ jobs:
run: |
config_file="_config_ci.yml"
echo "---" > $config_file
echo "baseurl: ${{ steps.configure-pages.outputs.base_path }}" >> $config_file
if [ "${{ inputs.base_url }}" == '_auto' ]; then
echo "baseurl: '${{ steps.configure-pages.outputs.base_path }}'" >> $config_file
else
echo "baseurl: '${{ inputs.base_url }}'" >> $config_file
fi

cat $config_file

Expand All @@ -186,6 +200,7 @@ jobs:
# if inputs.config_file exists
config_files="_config_ci.yml,_config_theme.yml"
if [ -e "${{ inputs.config_file }}" ]; then
cat ${{ inputs.config_file }}
config_files="${config_files},${{ inputs.config_file }}"
fi

Expand Down
Loading