Support loading offline MDS blobs in MetadataService#752
Open
MasterKale wants to merge 14 commits intomasterfrom
Open
Support loading offline MDS blobs in MetadataService#752MasterKale wants to merge 14 commits intomasterfrom
MasterKale wants to merge 14 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates
MetadataServicewith a newmdsBlobsargument ininitialize(). This argument accepts an array of MDS blobs that a project may wish to download and load offline, bundle with a worker, etc...To use it, pass in blobs like so:
The blob JWT will go through typical verification before the metadata statements within are loaded and available with a typical
MetadataService.getStatement()and during attestation statement verification inverifyRegistrationResponse().No effort will be made to refresh any stale MDS blobs passed into
mdsBlobs.Fixes #732.