Skip to content

fix(ai): add DB migration for per-vendor GPU quota #3353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zstack-robot-1 wants to merge 2 commits into
base: 5.5.6
Choose a base branch
from
Open

fix(ai): add DB migration for per-vendor GPU quota #3353

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
009c297
<fix>[ai]: add DB migration for per-vendor GPU quota
AlanJager Feb 9, 2026
cf4df42
<fix>[ai]: move GPU quota migration to V5.5.12 schema with backticks
AlanJager Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions conf/db/upgrade/V5.5.12__schema.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
-- ZSTAC-73546: Migrate existing global GPU quota to per-vendor (NVIDIA) quota
-- For users who already set container.gpu.video.ram.size, copy the value as NVIDIA vendor quota.
-- Other vendor quotas will use the GlobalConfig default (32GB) via the quota framework.
DELIMITER $$

CREATE PROCEDURE MigrateGpuQuotaPerVendor()
BEGIN
Comment on lines +6 to +7
Copy link

@coderabbitai coderabbitai bot Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

建议在创建存储过程前先 DROP，避免升级重跑失败。

若迁移在中途失败并重试，CREATE PROCEDURE 可能因已存在而报错中断升级。建议增加 DROP PROCEDURE IF EXISTS 以保证幂等性。

🔧 建议修改 
 DELIMITER $$
 
+DROP PROCEDURE IF EXISTS MigrateGpuQuotaPerVendor$$
+
 CREATE PROCEDURE MigrateGpuQuotaPerVendor()
 BEGIN
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
CREATE PROCEDURE MigrateGpuQuotaPerVendor()
BEGIN
DELIMITER $$
DROP PROCEDURE IF EXISTS MigrateGpuQuotaPerVendor$$
CREATE PROCEDURE MigrateGpuQuotaPerVendor()
BEGIN
🤖 Prompt for AI Agents 
In `@conf/db/upgrade/V5.5.12__schema.sql` around lines 6 - 7, Add idempotency by
dropping the stored procedure before creating it: ensure a DROP PROCEDURE IF
EXISTS MigrateGpuQuotaPerVendor() is executed immediately before the CREATE
PROCEDURE MigrateGpuQuotaPerVendor() statement so repeated/partial upgrade runs
won't fail due to the procedure already existing.

DECLARE done INT DEFAULT FALSE;
DECLARE v_identity_uuid VARCHAR(32);
DECLARE v_identity_type VARCHAR(255);
DECLARE v_value BIGINT;
DECLARE cur CURSOR FOR
SELECT `identityUuid`, `identityType`, `value`
FROM `QuotaVO`
WHERE `name` = 'container.gpu.video.ram.size';
DECLARE CONTINUE HANDLER FOR NOT FOUND SET done = TRUE;

OPEN cur;
read_loop: LOOP
FETCH cur INTO v_identity_uuid, v_identity_type, v_value;
IF done THEN
LEAVE read_loop;
END IF;

INSERT IGNORE INTO `QuotaVO` (`uuid`, `name`, `identityUuid`, `identityType`, `value`, `lastOpDate`, `createDate`)
VALUES (
REPLACE(UUID(), '-', ''),
'container.gpu.video.ram.size.nvidia',
v_identity_uuid,
v_identity_type,
v_value,
NOW(),
NOW()
);
END LOOP;
CLOSE cur;
END$$

DELIMITER ;

CALL MigrateGpuQuotaPerVendor();
DROP PROCEDURE IF EXISTS MigrateGpuQuotaPerVendor;