Open
Conversation
Also remove linguistics_data directory. We don't docstring this properly yet.
rocky
changed the title
WordTranslationWordTranslation
And another attempt to get CI working
rocky
force-pushed
the
add-WordTranslation
branch
from
6eb2264 to
0f209d4
Compare
rocky
force-pushed
the
add-WordTranslation
branch
from
0f209d4 to
d3a52ff
Compare
mmatera
reviewed
Jan 24, 2026
pymathics/natlang/translation.py
Outdated
| return String(language.name) | ||
|
|
||
|
|
||
| if have_lng: |
Contributor
There was a problem hiding this comment.
Instead of this conditional load, we could use the attribute 'requires'. See for example https://github.com/Mathics3/mathics-core/blob/c5388232f77b053012f20b7fe4ab2e53932d3c16/mathics/builtin/image/misc.py#L240
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also remove linguistics_data directory. We don't docstring this properly yet.