feat: restrict shell escape (!) in sandboxed mode#108
Merged
mmatera merged 1 commit intoMathics3:masterfrom Jan 31, 2026
Merged
feat: restrict shell escape (!) in sandboxed mode#108mmatera merged 1 commit intoMathics3:masterfrom
mmatera merged 1 commit intoMathics3:masterfrom
Conversation
Member
|
LGTM - and thanks! @mmatera your thoughts? |
mmatera
approved these changes
Jan 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restricts the shell escape command
!whensettings.ENABLE_SYSTEM_COMMANDSis False. This ensures that the shell frontend respects the sandbox model established inmathics-core.I've updated both the main loop and the interrupt loop to provide an explicit error message when a shell command is blocked.