Disable changes from #215 for .NET 6 FileStream breaking change#226
Closed
cupsos wants to merge 2 commits intoMelbourneDeveloper:developfrom
Closed
Disable changes from #215 for .NET 6 FileStream breaking change#226cupsos wants to merge 2 commits intoMelbourneDeveloper:developfrom
cupsos wants to merge 2 commits intoMelbourneDeveloper:developfrom
Conversation
https://github.com/dotnet/runtime/blob/e5eafc9bf8be55087dcc2907e9c4d6fa1c2e5773/src/libraries/System.Private.CoreLib/src/System/IO/FileStream.cs#L110 IsAsync provided by SafeFileHandle so we don't need to do
|
|
||
| #region Constructor | ||
| public ApiService(ILogger logger = null) => Logger = logger ?? NullLogger.Instance; | ||
| public ApiService(ILogger logger = null) |
There was a problem hiding this comment.
@cupsos I can see what this is about. I see the documentation from Microsoft.
Unfortunately, this is the wrong place to put this code. This service must remain dumb with no logic. We will need to pass the fileFlag in as part of the CreateConnection() method.
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #225