feat: add :createMultichainAccountGroups action to batch account creation

eslint-suppressions.json

@@ -1086,14 +1086,6 @@
       "count": 7
     }
   },
-  "packages/multichain-account-service/src/utils.ts": {
-    "@typescript-eslint/explicit-function-return-type": {
-      "count": 1
-    },
-    "id-denylist": {
-      "count": 1
-    }
-  },
   "packages/multichain-api-middleware/src/handlers/types.ts": {
     "@typescript-eslint/naming-convention": {
       "count": 2

packages/multichain-account-service/CHANGELOG.md

@@ -7,8 +7,17 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Added
+
+- Add new `createMultichainAccountGroups` support to create multiple groups in batch ([#7801](https://github.com/MetaMask/core/pull/7801))
+
 ### Changed
 
+- Optimize `EvmAccountProvider.createAccounts` for range operations ([#7801](https://github.com/MetaMask/core/pull/7801))
+  - Batch account creation with single a `withKeyring` call for entire range instead of one call per account.
+  - Batch account creation with single `keyring.addAccounts` call.
+  - Fetch all accounts in single `AccountsController:getAccounts` call instead of multiple `getAccount` calls.
+  - Significantly reduces lock acquisitions and API calls for batch operations.
 - Bump `@metamask/accounts-controller` from `^36.0.0` to `^36.0.1` ([#7996](https://github.com/MetaMask/core/pull/7996))
 
 ## [7.0.0]

packages/multichain-account-service/src/MultichainAccountGroup.ts

@@ -19,7 +19,7 @@ import type { MultichainAccountWallet } from './MultichainAccountWallet';
 import type { Bip44AccountProvider } from './providers';
 import { isAccountProviderWrapper } from './providers';
 import type { MultichainAccountServiceMessenger } from './types';
-import { createSentryError } from './utils';
+import { createSentryError, toErrorMessage } from './utils';
 
 export type GroupState =
   ServiceState[StateKeys['entropySource']][StateKeys['groupIndex']];
@@ -108,15 +108,6 @@ export class MultichainAccountGroup<
         }
       }
     }
-
-    if (this.#initialized) {
-      this.#messenger.publish(
-        'MultichainAccountService:multichainAccountGroupUpdated',
-        this,
-      );
-    } else {
-      this.#initialized = true;
-    }
   }
 
   /**
@@ -128,6 +119,8 @@ export class MultichainAccountGroup<
     this.#log('Initializing group state...');
     this.#setState(groupState);
     this.#log('Finished initializing group state...');
+
+    this.#initialized = true;
   }
 
   /**
@@ -139,6 +132,13 @@ export class MultichainAccountGroup<
     this.#log('Updating group state...');
     this.#setState(groupState);
     this.#log('Finished updating group state...');
+
+    if (this.#initialized) {
+      this.#messenger.publish(
+        'MultichainAccountService:multichainAccountGroupUpdated',
+        this,
+      );
+    }
   }
 
   /**
@@ -298,9 +298,7 @@ export class MultichainAccountGroup<
           return accounts;
         } catch (error) {
           // istanbul ignore next
-          this.#log(
-            `${WARNING_PREFIX} ${error instanceof Error ? error.message : String(error)}`,
-          );
+          this.#log(`${WARNING_PREFIX} ${toErrorMessage(error)}`);
           const sentryError = createSentryError(
             `Unable to align accounts with provider "${provider.getName()}"`,
             error as Error,

packages/multichain-account-service/src/MultichainAccountService-method-action-types.ts

@@ -141,6 +141,19 @@ export type MultichainAccountServiceCreateMultichainAccountGroupAction = {
   handler: MultichainAccountService['createMultichainAccountGroup'];
 };
 
+/**
+ * Creates multiple multichain account groups up to maxGroupIndex.
+ *
+ * @param params - Parameters for creating account groups.
+ * @param params.entropySource - The entropy source ID.
+ * @param params.maxGroupIndex - Maximum group index to create (0 to maxGroupIndex inclusive).
+ * @returns Array of created multichain account groups.
+ */
+export type MultichainAccountServiceCreateMultichainAccountGroupsAction = {
+  type: `MultichainAccountService:createMultichainAccountGroups`;
+  handler: MultichainAccountService['createMultichainAccountGroups'];
+};
+
 /**
  * Set basic functionality state and trigger alignment if enabled.
  * When basic functionality is disabled, snap-based providers are disabled.
@@ -186,6 +199,7 @@ export type MultichainAccountServiceMethodActions =
   | MultichainAccountServiceGetMultichainAccountGroupsAction
   | MultichainAccountServiceCreateNextMultichainAccountGroupAction
   | MultichainAccountServiceCreateMultichainAccountGroupAction
+  | MultichainAccountServiceCreateMultichainAccountGroupsAction
   | MultichainAccountServiceSetBasicFunctionalityAction
   | MultichainAccountServiceAlignWalletsAction
   | MultichainAccountServiceAlignWalletAction;