-
-
Notifications
You must be signed in to change notification settings - Fork 276
Mikesposito/refactor/simplify controller #7809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
wantedsystem
merged 7 commits into
feat/add-config-registry-controller
from
mikesposito/refactor/simplify-controller
Feb 6, 2026
Merged
Mikesposito/refactor/simplify controller #7809
wantedsystem
merged 7 commits into
feat/add-config-registry-controller
from
mikesposito/refactor/simplify-controller
Feb 6, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/config-registry-controller/src/ConfigRegistryController.ts
Outdated
Show resolved
Hide resolved
mikesposito
requested changes
Feb 2, 2026
packages/config-registry-controller/src/ConfigRegistryController.ts
Outdated
Show resolved
Hide resolved
packages/config-registry-controller/src/ConfigRegistryController.ts
Outdated
Show resolved
Hide resolved
packages/config-registry-controller/src/ConfigRegistryController.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Member
|
@wantedsystem I think we can merge this PR and continue working on the main feature branch. Thanks for addressing the feedback! |
c09c89d
into
feat/add-config-registry-controller
302 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Refactor / simplify config registry controller
References
Checklist
Note
Medium Risk
Changes controller state shape and polling/stop APIs, which can break consumers relying on
fetchError, filtered network storage, or token-based stop behavior. Network selection semantics also change (filtering moved to selectors; duplicate chainId handling now last-write-wins).Overview
Simplifies
ConfigRegistryControllerby removingfetchErrorand theNetworkConfigEntrywrapper, storing rawRegistryNetworkConfigobjects keyed bychainId.Moves network filtering from fetch-time to consumption-time by adding
selectNetworksandselectFeaturedNetworks(withreselect), and updates behavior to store all API networks while featured/active/non-testnet filtering is applied via selectors. DuplicatechainIdresolution is simplified to last-write-wins and the warning/priority logic is removed.Polling/stop behavior is streamlined: the messenger
stopPollingaction now stops all polling sessions (no token), delayed/placeholder-token logic is removed, and error handling now only reports viacaptureExceptionwithout mutating state/fallback bookkeeping. Tests, build config (excludetest-helpers.ts), and changelog are updated accordingly.Written by Cursor Bugbot for commit fd924fb. This will update automatically on new commits. Configure here.