Open
Conversation
- Improve test names - Don't assume default degraded threshold, but use constant - Don't wait when advancing timers so we don't need an extra `.catch(console.error)` - Ensure that `maxRetries` and `maxConsecutiveFailures` options are tested as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
.catch(console.error)maxRetriesandmaxConsecutiveFailuresoptions are tested as wellReferences
No tickets, but I was reviewing someone's PR and noticed some anti-patterns and deficiencies in the current tests.
Checklist
Note
Low Risk
Test-only changes: renames/clarifies assertions around degraded/retry/circuit-break behavior and makes timer advancement deterministic, with no production code impact.
Overview
Improves
SampleGasPricesServicetest coverage and clarity around service-policy behavior (degraded detection, retries, circuit breaker open/close).Tests now use
DEFAULT_DEGRADED_THRESHOLDinstead of a hardcoded value, advance Jest timers synchronously (removing async.catchworkarounds), and add explicit coverage thatpolicyOptionslikedegradedThreshold,maxRetries, andmaxConsecutiveFailuresare configurable.Written by Cursor Bugbot for commit 75ee10e. This will update automatically on new commits. Configure here.