Skip to content

CCM-12963 E2E Tests #340

Open
Namitha-Prabhu wants to merge 9 commits intomainfrom
feature/CCM-12963-E2ETests
Open

CCM-12963 E2E Tests #340
Namitha-Prabhu wants to merge 9 commits intomainfrom
feature/CCM-12963-E2ETests

Conversation

@Namitha-Prabhu
Copy link
Contributor

Description

https://nhsd-jira.digital.nhs.uk/browse/CCM-12963

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming
  • If I have used the 'skip-trivy-package' label I have done so responsibly and in the knowledge that this is being fixed as part of a separate ticket/PR.

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@Namitha-Prabhu Namitha-Prabhu requested a review from a team as a code owner January 13, 2026 13:36
(cherry picked from commit 5416cc7)
get_letter_data = requests.get(f"{url}/{LETTERS_ENDPOINT}/{letter_id}/data", headers=headers)

ErrorHandler.handle_retry(get_letter_data)
assert get_letter_data.status_code == 200, f"Response: {get_letter_data.status_code}: {get_letter_data.text}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm - the expected response from the API itself is a 303 that redirects to the download URL

If the client follows the redirect and resolves the link I think you get a 200 at that point

I assume that the test client resolves to the PDF?

Comment on lines +14 to +15

def test_202_with_valid_headers(url, bearer_token):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niggly - but can we remove the gaps between the annotations and the method please?

@pytest.mark.devtest
@pytest.mark.inttest
@pytest.mark.prodtest

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niggly - but can we remove the gaps between the annotations and the method please?

@pytest.mark.devtest
@pytest.mark.inttest
@pytest.mark.prodtest

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niggly - but can we remove the gaps between the annotations and the method please?

@pytest.mark.devtest
@pytest.mark.inttest
@pytest.mark.prodtest

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niggly - but can we remove the gaps between the annotations and the method please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants