Switch letter_status_update lambda to use eventsub SNS topic#360
Open
Switch letter_status_update lambda to use eventsub SNS topic#360
Conversation
stevebux
force-pushed
the
feature/CCM-12951-Maintain-Letter-Status
branch
2 times, most recently
from
b2a5207 to
94171d9
Compare
stevebux
force-pushed
the
feature/CCM-12951-Maintain-Letter-Status
branch
from
94171d9 to
966f6eb
Compare
Vlasis-Perdikidis
previously approved these changes
Jan 27, 2026
| return { | ||
| s3Client: new S3Client(), | ||
| sqsClient: new SQSClient(), | ||
| snsClient: new SNSClient(), |
Contributor
There was a problem hiding this comment.
for these clients we don't specify the region.
Are we sure they are assigned the correct region?
Contributor
Author
There was a problem hiding this comment.
As I understand it, when you create an AWS client inside a lambda, it inherits the region from where the lambda is executed. (Which will be eu-west-2 as that's what's configured in the terraform in the nhs-notify-internal project). I suppose that might be an issue for services that are only available in a limited number of regions, but that doesn't seem to be a problem here.
sidnhs
previously approved these changes
Jan 27, 2026
stevebux
dismissed stale reviews from sidnhs and Vlasis-Perdikidis
via
e5b9274
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.