Conversation
Signed-off-by: Charlene Yang <8636796+cyanguwa@users.noreply.github.com>
for more information, see https://pre-commit.ci
Greptile SummaryFixed backend availability checking logic in FP8 attention tests ( Key changes:
Confidence Score: 5/5
Important Files Changed
Last reviewed commit: 229b1ef |
|
/te-ci pytorch L3 |
| ) | ||
| _, fused_attn_supported, _ = available_backends | ||
| if not fused_attn_supported: | ||
| _, fused_attn_supported_f16, _ = available_backends |
There was a problem hiding this comment.
So if the value for fused_attn_supported_fp8=1/True and fp8_dpa_bwd=0/False then fused_attn_supported_f16 be 0/False or 1/True right ?
If fused_attn_supported_f16 is 0/False, there's no fp16 to compare the fp8 and hence we skip, but
,if fused_attn_supported_f16 is 1/True, then compare fp8 and fp16 fwd only.
Now, if fp8_dpa_bwd=1/True, then fused_attn_supported_f16 will be False/0 always
In that case what does fp8 get compared to ? Maybe I missed it, but I see no logic for this comparison - could you point me to it ?
There was a problem hiding this comment.
Makes sense. I removed the if not fp8_bwd logic. Could you please take a look at 229b1ef?
Signed-off-by: Charlene Yang <8636796+cyanguwa@users.noreply.github.com>
|
/te-ci pytorch L3 |
|
Pipeline 44991844. |
* fix L3 FA fp8 tests Signed-off-by: Charlene Yang <8636796+cyanguwa@users.noreply.github.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix skip logic based on reference backend Signed-off-by: Charlene Yang <8636796+cyanguwa@users.noreply.github.com> --------- Signed-off-by: Charlene Yang <8636796+cyanguwa@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Description
This PR fixes the L3 tests for FP8 current scaling in
L3_pytorch_FA_versions_test. The fix is only related to the selection logic in the test and not the backend support itself.Type of change
Changes
Please list the changes introduced in this PR:
Checklist: