test: add so password fields have the password OpenApi format#22761
Open
Mattias-Sehlstedt wants to merge 1 commit intoOpenAPITools:masterfrom
Open
test: add so password fields have the password OpenApi format#22761Mattias-Sehlstedt wants to merge 1 commit intoOpenAPITools:masterfrom
Mattias-Sehlstedt wants to merge 1 commit intoOpenAPITools:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 78 files
Note: This PR contains a large number of files. cubic only reviews up to 75 files per PR, so some files may not have been reviewed.
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="modules/openapi-generator/src/test/resources/1_2/petstore-1.2/user">
<violation number="1" location="modules/openapi-generator/src/test/resources/1_2/petstore-1.2/user:248">
P1: Missing comma before newly added format makes the User model JSON invalid.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
befd1ca to
d7c42a7
Compare
Contributor
Author
|
From the logs it looks like the python pipeline issues are nothing that is tied to my changes |
d7c42a7 to
8bd53b7
Compare
8bd53b7 to
01d82e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I saw that the AI-review comments on issues that are outside of scope but still relevant in general, so I thought they could be fixed so that they will not occur in the future.

(Image taken from #22726)
What I have done is that I have marked the password fields with
format: password, so that the generated code will properly use the generator functionality to censor the field when any explicit logging is invoked (e.g.,.toString()in Java).PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)Summary by cubic
Marked password fields with OpenAPI format: password across specs and samples so generators mask them in logs. This prevents accidental exposure (e.g., Java models now print "*" in toString).
Written for commit 01d82e7. Summary will update on new commits.