[php-symfony] fix sequencial escape when validating a class type#22906
[php-symfony] fix sequencial escape when validating a class type#22906wing328 merged 4 commits intoOpenAPITools:masterfrom
Conversation
|
thanks for the PR can you please review the build failure when you've time? |
|
Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors. Let me know if you need help fixing it. Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account Let me know if you need help fixing it. |
b3afaf6 to
c57b655
Compare
|
lgtm. let's give it a try thanks for the contribution |
In the api controller, validation is done using doubles quotes to check class type. This can lead to errors by interpreting a part of the string as an escaped character.
For exemple, if it compares class name like this one "\My\Namespace\Xcase", "\Xca" will be interpreted as an hexadecimal character and the validator will not match the class.
See https://www.php.net/manual/en/regexp.reference.escape.php for more informations.
Using single quotes fix the problem as strings are not interpreted as escaped ones.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)@jebentier, @dkarlovi, @mandrean, @jfastnacht, @ybelenko, @renepardon
Summary by cubic
Switch Assert\Type strings to single quotes in the PHP Symfony generator to prevent PHP escape-sequence interpretation during class type validation. Updated AppKernel testing template for Symfony 8 with a void return type; regenerated Symfony samples.
Written for commit 1652eb6. Summary will update on new commits.