Support numeric exclusiveMinimum/exclusiveMaximum in OpenAPI 3.1

[JohnBryte]

… (#22943)

PR checklist

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package || exit
  ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
  ./bin/utils/export_docs_generators.sh || exit
  

  (For Windows users, please run the script in WSL)
  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
• File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
• If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)

This PR solves following issue: Compatibility with exclusiveMinimum in OpenAPI 3.0.0 vs. 3.1.0

Description

OpenAPI 3.1 follows JSON Schema, where exclusiveMinimum/exclusiveMaximum can be specified as numeric values (e.g. exclusiveMinimum: 0) instead of the OpenAPI 3.0 boolean + minimum/maximum combination.

This PR updates the NORMALIZE_31SPEC rule in OpenAPINormalizer to handle the numeric 3.1 form by converting it into a 3.0-compatible shape that the generator already understands:

• exclusiveMinimum: → minimum = [number] and exclusiveMinimum = true
• exclusiveMaximum: → maximum = [number] and exclusiveMaximum = true

This keeps downstream validation/codegen logic unchanged (e.g. Bean Validation @DecimalMin/@DecimalMax generation continues to rely on minimum/maximum + boolean exclusivity).

Reproduction (minimal spec)

openapi: 3.1.0
info: { title: t, version: 1.0.0 }
paths:
  /x:
    get:
      operationId: getX
      parameters:
        - name: price
          in: query
          required: true
          schema:
            type: number
            exclusiveMinimum: 0
            exclusiveMaximum: 10
      responses:
        "200":
          description: ok

Tests
Adds a normalization test verifying that after OpenAPINormalizer runs with NORMALIZE_31SPEC=true, the schema has:
minimum=0, exclusiveMinimum=true
maximum=10, exclusiveMaximum=true

---

Summary by cubic

Adds support for numeric exclusiveMinimum/exclusiveMaximum in OpenAPI 3.1 and preserves the stricter bound when both numeric-exclusive and inclusive min/max are defined. Keeps validation and codegen consistent (e.g., Bean Validation annotations).

• Bug Fixes
  • Normalize 3.1 numeric exclusiveMinimum/exclusiveMaximum to minimum/maximum + exclusive=true in OpenAPINormalizer when NORMALIZE_31SPEC is enabled.
  • When min/max already exist, compare and keep the stricter constraint; set exclusive=true only when the exclusive bound is used.
  • Skip $ref schemas.
  • Add tests for numeric-only, stricter/equal/inclusive-dominant cases and Spring codegen; include a 3.1 sample spec. Fixes Compatibility with exclusiveMinimum in OpenAPI 3.0.0 vs. 3.1.0 #22943.

^{Written for commit 87795c7. Summary will update on new commits.}

[cubic-dev-ai]

1 issue found across 4 files

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="modules/openapi-generator/src/main/java/org/openapitools/codegen/OpenAPINormalizer.java">

<violation number="1" location="modules/openapi-generator/src/main/java/org/openapitools/codegen/OpenAPINormalizer.java:1894">
P2: Normalization ignores numeric exclusiveMinimum/Maximum when a minimum/maximum already exists, so schemas with both constraints lose the stricter exclusive bound after normalization.</violation>
</file>

---

Since this is your first cubic review, here's how it works:

• cubic automatically reviews your code and comments on bugs and improvements
• Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
• Add one-off context when rerunning by tagging @cubic-dev-ai with guidance or docs links (including llms.txt)
• Ask questions if you need clarification on any suggestion

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[wing328]

looks good to me. thanks for the contribution.