[cpp-qt-client]Fix variable redeclarations in the api-body.mustache#22982
Open
martonmiklos wants to merge 1 commit intoOpenAPITools:masterfrom
Open
[cpp-qt-client]Fix variable redeclarations in the api-body.mustache#22982martonmiklos wants to merge 1 commit intoOpenAPITools:masterfrom
martonmiklos wants to merge 1 commit intoOpenAPITools:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 3 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="modules/openapi-generator/src/main/resources/cpp-qt-client/api-body.mustache">
<violation number="1" location="modules/openapi-generator/src/main/resources/cpp-qt-client/api-body.mustache:752">
P2: Typo introduces non-existent `{{prefix}}HttpRequestWorker4` type in implicit flow pending-request check, which will not compile and breaks request counting.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
modules/openapi-generator/src/main/resources/cpp-qt-client/api-body.mustache
Outdated
Show resolved
Hide resolved
a0ba95b to
edc984a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generated code failed to compile if and endpoint had oauth2 enabled.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)Summary by cubic
Fixes C++ Qt client code generation for OAuth2 endpoints by preventing variable redeclarations in api-body.mustache. Generated clients now compile with OAuth2 auth.
Written for commit edc984a. Summary will update on new commits.