Skip to content

[cpp-qt-client]Fix variable redeclarations in the api-body.mustache#22982

Open
martonmiklos wants to merge 1 commit intoOpenAPITools:masterfrom
martonmiklos:fix_openapi_schema_and_token_decl_for_qt_client
Open

[cpp-qt-client]Fix variable redeclarations in the api-body.mustache#22982
martonmiklos wants to merge 1 commit intoOpenAPITools:masterfrom
martonmiklos:fix_openapi_schema_and_token_decl_for_qt_client

Conversation

@martonmiklos
Copy link
Contributor

@martonmiklos martonmiklos commented Feb 15, 2026

The generated code failed to compile if and endpoint had oauth2 enabled.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Fixes C++ Qt client code generation for OAuth2 endpoints by preventing variable redeclarations in api-body.mustache. Generated clients now compile with OAuth2 auth.

  • Bug Fixes
    • Use flow-specific scope and token variables (scope1–scope4, token1–token4) and set _latestScope to the matching list to avoid collisions across OAuth2 flows.
    • Regenerated petstore samples to reflect the changes.

Written for commit edc984a. Summary will update on new commits.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 3 files

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="modules/openapi-generator/src/main/resources/cpp-qt-client/api-body.mustache">

<violation number="1" location="modules/openapi-generator/src/main/resources/cpp-qt-client/api-body.mustache:752">
P2: Typo introduces non-existent `{{prefix}}HttpRequestWorker4` type in implicit flow pending-request check, which will not compile and breaks request counting.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

@martonmiklos martonmiklos force-pushed the fix_openapi_schema_and_token_decl_for_qt_client branch from a0ba95b to edc984a Compare February 15, 2026 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant