-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Feat: tooltip enhancement #532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the solid implementation here — this is a meaningful UX improvement and very close to merge-ready! Here are two small follow-ups before merge:
|
I have udpated accordingly |
|
Thanks for addressing the previous round of feedback so quickly — the updates are appreciated! One more UX request before merge: Could we add a user setting to globally enable/disable help tooltips?
This should live in Settings (same place as Suggested key name: When disabled, we should bypass RichTooltip rendering across workflow UI (node tooltips, edge tooltip trigger, context-menu/action button tooltips), while keeping all existing behavior unchanged when enabled. Also, I noticed the edge tooltip position seems incorrect right now (it’s not rendering at the edge/midpoint as expected). Could you take a look at that in this PR as well? |
|
I have moved it to config options in settings, and the tooltip should be more in the middle now |
zxrys
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
This will resolve #520
Key Changes: