Read env vars for server name and env name#46
Open
rogin wants to merge 1 commit intoOpenIntegrationEngine:mainfrom
Open
Read env vars for server name and env name#46rogin wants to merge 1 commit intoOpenIntegrationEngine:mainfrom
rogin wants to merge 1 commit intoOpenIntegrationEngine:mainfrom
Conversation
Contributor
|
This PR eliminates the need for booter mcgooter |
jonbartels
previously approved these changes
Apr 20, 2025
tonygermano
reviewed
Jul 14, 2025
Member
tonygermano
left a comment
tonygermano
left a comment
There was a problem hiding this comment.
question: would the configuration controller be a more appropriate place for this functionality?
Or is there a reason it must be in Mirth.java?
Contributor
Author
Yep, a single call to the controller is likely cleaner. |
Signed-off-by: Richard Ogin <rogin@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written to fix my own request here. NextGen merged it into their 4.6.0 release, so it's missing here.
Original test notes written here:
Used a freshly built server under /server/setup.
Start server with java -jar .\mirth-server-launcher.jar, and bring the server down after each test.
Test 1: No envvars set. Start server. Complete the admin change password modal. Validate values are blank in UI.
Test 2: set envvar MC_SERVER_NAME = 'Staging'. Start server. Validate its value in UI.
Test 3: set envvar MC_ENV_NAME = 'Sys-001'. Start server. Validate both values in UI.
Test 4: set envvar MC_SERVER_NAME = 'Prod', MC_ENV_NAME = 'Sys-002'. Start server. Validate both values in UI.
Test 5: Unset envvars MC_SERVER_NAME and MC_ENV_NAME. Start server. Validate both values in UI are same used in test 4 (as they've been stored in DB).