Skip to content

[Feature] support mm_processor_kwargs for flexible model#6490

Merged
lizhenyun01 merged 1 commit intoPaddlePaddle:developfrom
Wanglongzhi2001:fix_mm_processor_kwargs_dev
Feb 25, 2026
Merged

[Feature] support mm_processor_kwargs for flexible model#6490
lizhenyun01 merged 1 commit intoPaddlePaddle:developfrom
Wanglongzhi2001:fix_mm_processor_kwargs_dev

Conversation

@Wanglongzhi2001
Copy link
Collaborator

Motivation

support mm_processor_kwargs for flexible model

💡 If this PR is a Cherry Pick, the PR title needs to follow the format by adding the [Cherry-Pick] label at the very beginning and appending the original PR ID at the end. For example, [Cherry-Pick][CI] Add check trigger and logic(#5191)

💡 如若此PR是Cherry Pick,PR标题需遵循格式,在最开始加上[Cherry-Pick]标签,以及最后面加上原PR ID,例如[Cherry-Pick][CI] Add check trigger and logic(#5191)

Modifications

Usage or Command

Accuracy Tests

Checklist

  • Add at least a tag in the PR title.
    • Tag list: [[FDConfig],[APIServer],[Engine], [Scheduler], [PD Disaggregation], [Executor], [Graph Optimization], [Speculative Decoding], [RL], [Models], [Quantization], [Loader], [OP], [KVCache], [DataProcessor], [BugFix], [Docs], [CI], [Optimization], [Feature], [Benchmark], [Others], [XPU], [HPU], [GCU], [DCU], [Iluvatar], [Metax]]
    • You can add new tags based on the PR content, but the semantics must be clear.
  • Format your code, run pre-commit before commit.
  • Add unit tests. Please write the reason in this PR if no unit tests.
  • Provide accuracy results.
  • If the current PR is submitting to the release branch, make sure the PR has been submitted to the develop branch, then cherry-pick it to the release branch with the [Cherry-Pick] PR tag.

@paddle-bot
Copy link

paddle-bot bot commented Feb 24, 2026

Thanks for your contribution!

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (develop@38c3e02). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #6490   +/-   ##
==========================================
  Coverage           ?   69.51%           
==========================================
  Files              ?      391           
  Lines              ?    52809           
  Branches           ?     8225           
==========================================
  Hits               ?    36710           
  Misses             ?    13432           
  Partials           ?     2667           
Flag Coverage Δ
GPU 69.51% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@JiangJiajunAI JiangJiajunAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

整体评价

这是一个很好的功能补充PR,为flexible model的plugin processor添加了mm_processor_kwargs参数支持。

👍 做得好的地方

  1. 接口一致性:使plugin processor与内置的多模态processor(如Ernie4_5_VLProcessorPaddleOCRVLProcessor等)保持相同的参数接口
  2. 代码简洁:改动最小化,只添加了必要的参数传递
  3. 向后兼容:由于代码在try-except块中,即使plugin不支持这个参数也会fallback到内置processor,不会导致完全失败

💡 建议

如果有plugin processor的话,建议同步更新plugin的接口文档,确保所有plugin都支持mm_processor_kwargs参数,以充分利用这个feature。

整体评价:LGTM

@lizhenyun01 lizhenyun01 merged commit 14ea724 into PaddlePaddle:develop Feb 25, 2026
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants