Add GET /lookups/ranges endpoint for lookup range brackets#7
Draft
gsayer wants to merge 1 commit intoPayroll-Engine:mainfrom
Draft
Add GET /lookups/ranges endpoint for lookup range brackets#7gsayer wants to merge 1 commit intoPayroll-Engine:mainfrom
gsayer wants to merge 1 commit intoPayroll-Engine:mainfrom
Conversation
… with computed upper bounds
Added LookupRangeBracket and LookupRangeResult POCOs, BuildRangeBrackets extension method on LookupSet, API DTOs, Mapperly mappers, and payroll controller endpoint at {payrollId}/lookups/ranges supporting threshold and progressive range modes with optional range value matching. Updated swagger.json with new path and component schemas.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2a07b3b to
8fd72be
Compare
Contributor
|
@gsayer Thank you for this useful extension. There are two conceptual points that we should consider: Closed value rangesCurrently, the ActionChange the value of Unique lookup bracketThe result should be that I get one bracket for each range value only. Currently, the ActionThe var precision = (decimal)Math.Pow(10, -SystemSpecification.DecimalScale);
currentBracket.UpperBound = nextBracket.LowerBound - precision; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /api/tenants/{tenantId}/payrolls/{payrollId}/lookups/rangesendpoint that returns lookup range brackets with computed upper boundsLookupSetExtensionsbut previously not accessible via the APIMotivation
Current lookup endpoints return either raw values (without computed bounds) or a single matched value. There is no way to retrieve the complete bracket structure (lower + upper bounds) through the API. This is needed for contribution preview in salary simulation case (For example, giving visibility of the social contribution threshold based on employee cases).
New endpoint
Returns
LookupRangeResult[]withallBrackets,matchingBracket(threshold),matchingBrackets(progressive).Changes
LookupRangeBracket.cs,LookupRangeResult.cs,LookupSetExtensions.csBuildRangeBrackets()methodLookupRangeBracket.cs,LookupRangeResult.csLookupRangeBracketMap.cs,LookupRangeResultMap.csPayrollController.csPayrollController.cs[HttpGet("{payrollId}/lookups/ranges")]Test plan
dotnet buildpasses with TreatWarningsAsErrorsdotnet testpassesmatchingBracketreturned for a givenrangeValuematchingBracketsreturnedrangeSizefor last bracket)lookupNames