Conversation
dlebauer
left a comment
There was a problem hiding this comment.
@cnaples79 thanks for this contribution! I added a few components from the version in the SIPNET repository. Need to confirm that this works before merging; feel free to remove problematic args that I suggested.
| - name: Run lychee | ||
| uses: lycheeverse/lychee-action@v1.10.0 | ||
| with: | ||
| args: "--verbose --no-progress --exclude-mail" |
There was a problem hiding this comment.
These settings were helpful in the SIPNET link checker - mostly in making the workflow more robust to common non-errors. Please consider whether they will be helpful here.
| args: "--verbose --no-progress --exclude-mail" | |
| args: >- | |
| --verbose --no-progress --exclude-mail | |
| --include-fragments | |
| --no-progress | |
| --verbose | |
| --timeout 20 | |
| --max-redirects 10 | |
| --max-retries 3 | |
| --retry-wait-time 2 | |
| --format markdown | |
| --exclude '^https://doi\.org/' | |
| . | |
| fail: true |
There was a problem hiding this comment.
remove --include-fragments initially (or add exclusions). if problematic.
| with: | ||
| args: "--verbose --no-progress --exclude-mail" | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | |
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | |
| - name: Upload lychee report | |
| if: ${{ always() }} | |
| uses: actions/upload-artifact@v4 | |
| with: | |
| name: lychee-report | |
| path: lychee |
remove extra blank line
dlebauer
left a comment
There was a problem hiding this comment.
@cnaples79 I ran the workflow (without my suggestions) and it passed. But we have three current issues open that reported broken links: #60, #136, and #137.
Do you know why this would be or what the fix would be?
This PR should fix those broken link issues and close #135
Thanks again for your help with this!
|
Note - once this is merged we should consider whether we should re-enable the rule that requires the link checker to pass before merging PRs, or how we should be notified. |
Summary
Rationale
Automated link checking helps catch broken links early without relying on manual checks.
Changes
Test Plan
Fixes #134