fix a crash issue and update sdk version#5376
Open
waertf wants to merge 2 commits intoPhilJay:masterfrom
Open
Conversation
…d chart disappear update compileSdkVersion to 33 and gradle version to 7.2 fix the issue that cannot build add MPChartLib binary release update read me setup for Lib binary Setup
waertf
changed the title
waertf
changed the title
hannesa2
added a commit
to AppDevNext/AndroidChart
that referenced
this pull request
Feb 2, 2023
Cahnges are from PhilJay#5376
hannesa2
added a commit
to AppDevNext/AndroidChart
that referenced
this pull request
Feb 2, 2023
Changes are from PhilJay#5376
hannesa2
reviewed
Feb 2, 2023
Contributor
hannesa2
left a comment
hannesa2
left a comment
There was a problem hiding this comment.
I use most interesting parts in AppDevNext#100 because the other changes are mostly already applied in my fork.
MPChartLib/src/main/java/com/github/mikephil/charting/charts/CombinedChart.java
Show resolved
Hide resolved
Author
|
reformat as hannesa2 suggested |
Contributor
|
merged in AppDevNext#100 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist:
PR Description
Fix null pointer exception in draw markers after real time highlighted chart disappear
update compileSdkVersion to 33 and gradle version to 7.2
add MPChartLib binary release
update read me setup for Lib binary Setup