Skip to content

Feat/render logic#44

Open
ZigmaZero wants to merge 95 commits intomainfrom
feat/render-logic
Open

Feat/render logic#44
ZigmaZero wants to merge 95 commits intomainfrom
feat/render-logic

Conversation

@ZigmaZero
Copy link
Collaborator

No description provided.

ZigmaZero and others added 30 commits September 22, 2025 15:35
lolpopih845 and others added 28 commits January 21, 2026 17:03
still has linker error, but im so tired rn
i'll ask nack about it when he's out of game jam
@ZigmaZero ZigmaZero requested a review from nack098 February 4, 2026 14:25
Copy link
Collaborator

@nack098 nack098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please answer first?

struct Homing
{
bool targetPlayer;
Physics::Position targetPosition;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be using as entity's component? i mean using in this is fine but it will create cache missed

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lolpopih845 Please check

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not quite understand but my general answer is that homing should be a component for changing its angle or angular velocity toward the target. Those fields I wrote was too board for general usecase so in my next push I'm gonna delete those + delay perhaps (If I found a way to add component to bullet on runtime with DSL that would be perfect).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then do it as a component for that entity because if you do it like this struct size will be increase that won't fit cache line.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's updated in the relevant branch now. Should I merge it in?

{
struct TimingEnd
{
int timing_end;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

int?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

int. component timing is currently all int.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need signed for it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean technically probably, there might be a bit of subtraction later on, so keeping it signed removes that headache for now (and hope nothing lasts 20 million seconds)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments