Skip to content

fix: replace 5 bare except clauses with except Exception #1313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
haosenwang1018 wants to merge 1 commit into from
+5 −5
Closed

fix: replace 5 bare except clauses with except Exception #1313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pycodestyle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1518,7 +1518,7 @@ def bare_except(logical_line, noqa):

Okay: except Exception:
Okay: except BaseException:
E722: except:
E722: except Exception:
"""
if noqa:
return
Expand Down
6 changes: 3 additions & 3 deletions testing/data/E72.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,14 +55,14 @@ def func_histype(a, b, c):
#: E722
try:
pass
except:
except Exception:
pass
#: E722
try:
pass
except Exception:
pass
except:
except Exception:
pass
#: E722 E203 E271
try:
Expand All @@ -73,7 +73,7 @@ def func_histype(a, b, c):
fake_code = """"
try:
do_something()
except:
except Exception:
pass
"""
try:
Expand Down
2 changes: 1 addition & 1 deletion testing/data/E90.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
while True:
try:
pass
except:
except Exception:
print 'Whoops'
#: Okay

Expand Down
Loading