Update on AG Grid data viewer, and use infinite row model for dynamic data loading#1610
Open
Fred-Wu wants to merge 17 commits intoREditorSupport:masterfrom
Open
Update on AG Grid data viewer, and use infinite row model for dynamic data loading#1610Fred-Wu wants to merge 17 commits intoREditorSupport:masterfrom
Fred-Wu wants to merge 17 commits intoREditorSupport:masterfrom
Conversation
Author
|
added 2 commits
May 9, 2025 23:36
Author
|
4e55cf7 to
77054c6
Compare
Author
|
I think I have made all the changes I want. Would like someone interested in this to take a look, and provide feedback on errors I missed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem did you solve?
Fixed the issue that multiple data viewer would open by calling
View()for the same data. The fix introduceddataview_uuid, and check whether the same window has been opened or not. It will create a window if it has been closed, but refresh the window if it has been opened already.Changed the AG Grid data viewer to
infiniterow model, which allows dynamic data loading, even for very large data. The changes includeshowDataViewunder/src/session.ts;dataview_table()in/R/session/vsc.Rto manage the request for sorting and filtering based on AG Grid options and data types, such asnumber (numeric),text (character),date (Date),boolean (logical);data.tablea required package to be installed.;- row Id column
(row)now shows row number from 1 to N even after sorting and filtering. The header name(row)was replaced by(# filtered rows) / (# total rows)- Boolean column initially showed as "true/false" has been changed to "TRUE/FALSE". This is treated as a numeric column, and only
Equalsoption is enabled, with hint to use 1 for TRUE, and 0 for FALSE when apply a filter on this column.- filtering pane is now below header name so that one could see what have been filtered with what values.
Would love to hear your feedbacks on this and whether this change would be something you consider to incorporate.
(If you have)Screenshot
demo1.mp4
n = 1e7demo2_small.mp4
n = 1e8demo3_small.mp4