Default to radian console if rterm.preferRadian is true#1625
Open
BerriJ wants to merge 3 commits intoREditorSupport:masterfrom
Open
Default to radian console if rterm.preferRadian is true#1625BerriJ wants to merge 3 commits intoREditorSupport:masterfrom
BerriJ wants to merge 3 commits intoREditorSupport:masterfrom
Conversation
…lts to false) rterm.preferRadian defaults to false so vanilla R is used by default.
Contributor
|
Would it make more sense to make R and radian selectable via an Enum? I recently created the arf console that can be used instead of radian, and I have personally switched from radian. |
Author
This would also work. You mean something like: And then this extension would search the PATH for arf, radian, and r, and use the first it finds? This would be a very flexible solution. |
|
+1 on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will close #1347
It adds a new option
rterm.preferRadianwhich defaults tofalse.If
falsenothing changes.If
rterm.preferRadianistrueand the user did not specify a path manually (r.rterm.linux for example). Then vscode-R looks for radian on the PATH and uses it. If radian is not found, it falls back to R.I would be really happy if this could get merged. I'm also happy to adjust as needed. I deliberately set the default to
falseso merging this will not change how vscode-R behaves until the user explicitly sets that setting to true. As discussed in the PR, using radian from the PATH can be very helpful in environments where the path to theradianbinary is not static.Thank you so much for this project. I'm a daily user since many years.
Best,
BerriJ