-
Notifications
You must be signed in to change notification settings - Fork 352
feat:添加tm1668软件包 #1963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat:添加tm1668软件包 #1963
Conversation
|
@Rbb666 帮审下 谢谢 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a new peripheral package tm1668 to the RT-Thread Packages repository. The tm1668 is an LED driver chip controlled via a 3-pin interface. The author (龚金华/GKoSon) has previously contributed similar packages to the repository (bt24s, ikunLed, ins5t8025).
Changes:
- Added
peripherals/tm1668/package.jsonwith package metadata pointing to https://github.com/GKoSon/tm1668 - Added
peripherals/tm1668/Kconfigwith configuration options for the package including pin name settings - Updated
peripherals/Kconfigto source the new package's Kconfig file
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| peripherals/tm1668/package.json | Defines package metadata including name, description, author, license, and repository URL with only "latest" version |
| peripherals/tm1668/Kconfig | Provides menuconfig options for the package including version selection and pin configuration |
| peripherals/Kconfig | Adds source statement to integrate tm1668 package into the build system |
| "site": [ | ||
| { | ||
| "version": "latest", | ||
| "URL": "https://github.com/GKoSon/tm1668.git", | ||
| "filename": "tm1668.zip", | ||
| "VER_SHA": "main" | ||
| } | ||
| ] |
Copilot
AI
Feb 6, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟠 [package.json/包信息]: Missing fixed version entry / 缺少固定版本条目
English: According to RT-Thread Packages repository policy, packages should provide at least one fixed version (e.g., v1.0.0) in addition to "latest". The "site" array currently only includes "latest" pointing to the "main" branch. Please add a fixed version entry with an immutable tag or commit reference. This ensures users can select a stable, tested version.
Example format:
"site": [
{
"version": "v1.0.0",
"URL": "https://github.com/GKoSon/tm1668/archive/refs/tags/v1.0.0.zip",
"filename": "tm1668-1.0.0.zip",
"VER_SHA": "NULL"
},
{
"version": "latest",
"URL": "https://github.com/GKoSon/tm1668.git",
"filename": "tm1668.zip",
"VER_SHA": "main"
}
]中文:根据 RT-Thread Packages 仓库规范,软件包应提供至少一个固定版本(例如 v1.0.0),而不仅仅是"latest"。当前"site"数组仅包含指向"main"分支的"latest"。请添加一个固定版本条目,使用不可变的 tag 或 commit 引用。这确保用户可以选择稳定且经过测试的版本。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
增加了tag 标记版本
peripherals/tm1668/Kconfig
Outdated
| choice | ||
| prompt "Version" | ||
| default PKG_USING_TM1668_LATEST_VERSION | ||
| help | ||
| Select the package version | ||
|
|
||
| config PKG_USING_TM1668_LATEST_VERSION | ||
| bool "latest" | ||
| endchoice | ||
|
|
||
| config PKG_TM1668_VER | ||
| string | ||
| default "latest" if PKG_USING_TM1668_LATEST_VERSION | ||
|
|
Copilot
AI
Feb 6, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 [Kconfig/Kconfig]: Missing version choice for fixed version / 缺少固定版本的选项
English: The Kconfig only includes a choice for "latest" version. When a fixed version (e.g., v1.0.0) is added to package.json, you should also add a corresponding config option in the version choice section. This allows users to select the fixed version through menuconfig.
Example:
choice
prompt "Version"
default PKG_USING_TM1668_LATEST_VERSION
help
Select the package version
config PKG_USING_TM1668_V100
bool "v1.0.0"
config PKG_USING_TM1668_LATEST_VERSION
bool "latest"
endchoice
config PKG_TM1668_VER
string
default "v1.0.0" if PKG_USING_TM1668_V100
default "latest" if PKG_USING_TM1668_LATEST_VERSION
中文:Kconfig 仅包含"latest"版本的选项。当在 package.json 中添加固定版本(例如 v1.0.0)后,您还应在版本选择部分添加相应的配置选项。这允许用户通过 menuconfig 选择固定版本。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
增加了tag 标记版本
peripherals/tm1668/Kconfig
Outdated
| config PKG_TM1668_VER | ||
| string | ||
| default "latest" if PKG_USING_TM1668_LATEST_VERSION | ||
|
|
Copilot
AI
Feb 6, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 [best_practices/最佳实践]: Trailing whitespace on line 27 / 第 27 行有尾随空格
English: Line 27 contains trailing whitespace. Please remove it to maintain code cleanliness and consistency with repository standards.
中文:第 27 行包含尾随空格。请移除以保持代码整洁性并符合仓库标准。
修改其二
Removed unnecessary header comment from package.json.
本地项目HC32F460验证成功 3PIN驱动TM1668 可以用TM1668做灯板