Open
Conversation
| { | ||
| ForceUpdateDelayedUVGeneration(); | ||
| DelayedUVGeneration(force: true); | ||
| } |
Member
There was a problem hiding this comment.
Sorry for the late comment, I was on vacation and then forgot .. 😬
Also, it's been a while since I looked at this particular code
So, DelayedUVGeneration works on all models, so this is not the right place for this.
In UpdateModels() DelayedUVGeneration is called, after all models are done, and it should already run if ForceUpdateDelayedUVGeneration has been called before
So just calling ForceUpdateDelayedUVGeneration here should be enough
Author
There was a problem hiding this comment.
Sounds good. I haven't tested it with just ForceUpdateDelayedUVGeneration() but if you are sure, we can resolve this :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The UVs were somehow not generated on a model with Auto UV Generation turned on, causing baked lightmaps to be incorrect.
I put in this hack and it fixed the problem for me.