Convert remaining DATAPTR to DATAPTR_RO#1359
Merged
eddelbuettel merged 2 commits intomasterfrom Mar 10, 2025
Merged
Conversation
Contributor
|
LGTM! |
Member
Author
|
🤞 Rev deps looking good too so far, but it's only been a fraction... |
Contributor
|
We probably need some way of eventually deprecating / removing this, but that feels like a "Later" kind of issue. |
Member
Author
|
With the |
Member
Author
|
No changes to worse or new issues. (A few packages added since last run had new depends, they will get re-tested in the next one I do for CLOENV (which is an 'empty' test as the condition will only for R 4.5.0 or later and we test with 4.4.*). So merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As CRAN checks nag about the one remaining
DAtAPTRuse, a quick change toDATAPTR_ROwhich should pass for all reasonable use cases. Running full reverse-depends checks now (which will take its usual time ... measured in days now) to determine if anybody out there "is naughty" instead of nice.Checklist
R CMD checkstill passes all tests