Cleanup __cplusplus checks

[Enchufa2]

Closes #1370.

Checklist

• Code compiles correctly
• R CMD check still passes all tests
• Preferably, new tests were added which fail without the change
• Document the changes by file in ChangeLog

[eddelbuettel]

Nice work. I had eyed this as upcoming (ie file cleanup / removal) for exceptions_ but not worked it out in any detail and not realized that we can e.g. simplify the LONG_LONG bit. The exceptions bit is also good. I had not realized the RCPP_ADVANCED_EXCEPTION_CLASS by @coatless was not actually use in the C++11 header he defined 😉

I will give all this a drive on the reverse-depends machine, ok? (Where I am slowly adding more to the blacklist to skip the very worst offenders.)

[Enchufa2]

About the Copyright line, I didn't add myself where I just removed code. :)

[coatless]

It's been a hot minute (~8 years) since I last looked at that; but, wasn't the macro used later on?

Rcpp/inst/include/Rcpp/exceptions.h

Lines 243 to 244 in fcf959b

	RCPP_ADVANCED_EXCEPTION_CLASS(not_compatible, "Not compatible" ) // #nocov end
	RCPP_ADVANCED_EXCEPTION_CLASS(index_out_of_bounds, "Index is out of bounds")

[eddelbuettel]

Yes: @Enchufa2 moved it up a level into the exceptions file itself. What got removed what the C++98-vs-C++11 split and we continue with the latter as a default. See eaa119a for his commit, and #1365 as our governing issue with sub-issues (!!).

So I think my hot comment this morning was also partly off. The better news is that even on the sloooow machine used, the reverse depends trains is now at 336 winners, a few skipped and one unrelated fail for lack of (new) build-depends. Moving along...

[eddelbuettel]

All clear from the rev.dep check, as everybody rightly expected. So merging. Thanks for this nice pice of work @Enchufa2 !