Use message() to signal very old helper functions are redundant (closes #1412)#1413
Use message() to signal very old helper functions are redundant (closes #1412)#1413eddelbuettel merged 1 commit intomasterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #1412 by adding informative deprecation messages to six helper functions (RcppLdPath, RcppLdFlags, CxxFlags, LdFlags, RcppCxx0xFlags, and Cxx0xFlags) that have been redundant since 2013. The messages use message() to gently notify users that these functions may be removed in 2027, with a recommendation to update their Makevars files.
Key Changes:
- Added consistent deprecation messages to six long-redundant helper functions using
message() - Updated ChangeLog to document the changes
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| R/RcppLdpath.R | Added message() calls to six deprecated helper functions to inform users of their redundancy and potential future removal |
| ChangeLog | Documented the addition of deprecation warnings via message() for the affected functions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
|
This is ready for review as well now as the reverse-dependency run passed without any issues. |
This simple PR addresses the issue raised in #1412 about the long-redundant helper functions that were prior to 2013 (!!) to constrct working
src/Makevars*but have not been needed since.A reverse-dependency check has been started. I will keep it as 'draft' until that is done (likely Monday).
Checklist
R CMD checkstill passes all tests