feature: copy transcript and dark mode icon by nilleb · Pull Request #14 · RecapAI/Recap

nilleb · 2025-09-25T04:54:44Z

Description

Once the system transcription was working, I attempted to implement a feature I needed: copying the transcription text.
I have also enabled the transcript timestamps (supported by WhisperKit).

The format of the transcript for the moment looks like

<|startoftranscript|><|en|><|transcribe|><|0.00|> (applause)<|2.00|> <|2.00|> of an unprecedented fix.<|4.00|> <|4.00|> After almost 23 years on the air,<|7.00|> <|7.00|> we're suddenly not being broadcast in 20% of the country,<|10.00|> <|10.00|> which is not a situation we relish.<|12.00|> <|12.00|> So we reached out to the chairman of the FCC, Brendan Karn.<|17.00|> <|17.00|> He has, to his credit, agreed to join us<|19.00|> <|19.00|> from his office in Washington and Washington, D.C.<|23.00|> <|23.00|> to be the president of the FCC.<|25.00|> <|25.00|> And he has, to his credit, agreed to join us<|28.00|> <|startoftranscript|><|en|><|transcribe|><|0.00|> office in Washington and here he is now.<|2.96|> <|2.96|> Thank you Chairman Carr for being with us tonight.<|4.80|> <|startoftranscript|><|en|><|transcribe|><|0.00|> (audience cheering)<|0.76|><|endoftext|>

[User Audio Note: The following was spoken by the user during this recording. Please incorporate this context when creating the meeting summary:]

<|startoftranscript|><|en|><|transcribe|><|0.00|> Let's watch a video together.<|7.00|><|endoftext|> <|startoftranscript|><|en|><|transcribe|><|0.00|> here is now thank you chairman corn for being with us tonight<|5.20|> <|5.20|> so what is the name of the chairman of the fcc for the next time<|11.12|> <|11.12|> please add this as an action item<|15.84|> <|startoftranscript|><|en|><|transcribe|><|0.00|> [ Silence ]<|3.98|><|endoftext|>

[End of User Audio Note. Please align the above user input with the meeting content for a comprehensive summary.]

I plan to change the format of the transcript text soon to match something like

0s: Microphone: let's watch a video together
0s: System Audio: (applause)
[..]

This PR also contains the icon for dark mode.

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation update
Test improvement

Testing

Unit tests pass locally
New tests have been added for new functionality
Existing tests have been updated if needed

Checklist

I have performed a self-review of my own code
I have commented my code where necessary (following the no-comments rule)
My changes generate no new warnings
Any dependent changes have been merged and published

Screenshots (if applicable)

Additional Notes

You must resolve #12 before merging this pull request. This code is hereby granted only if this software is licensed with an open-source license.

rawandahmad698 · 2025-09-29T14:28:35Z

Will review

Copilot

Pull Request Overview

This PR implements two major features: a copy transcript functionality for copying transcription text to clipboard and system-wide audio recording capabilities. It also includes foundational work for timestamped transcription support and various UI improvements.

Adds copy transcription button alongside the existing copy summary functionality
Implements system-wide audio recording via SystemWideTap for capturing all system audio rather than specific applications
Introduces timestamped transcription models and utilities with WhisperKit integration

Reviewed Changes

Copilot reviewed 44 out of 51 changed files in this pull request and generated 11 comments.

Show a summary per file

File	Description
cli	New build script for managing Xcode operations
SummaryView.swift	Adds copy transcription button to UI
SummaryViewModel.swift	Implements copyTranscription() method
TranscriptionService.swift	Enhanced with timestamped transcription support
SystemWideTap.swift	New system-wide audio capture implementation
AudioRecordingCoordinator.swift	Updated to support both process-specific and system-wide recording
RecordingInfo.swift	Added timestampedTranscription field
SelectableApp.swift	Added "All Apps" option for system-wide recording
Assets.xcassets	Added dark mode icon assets

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-29T14:32:30Z

Recap/Repositories/Recordings/RecordingRepository.swift

+                do {
+                    let recording = try self.fetchRecordingEntity(id: id, context: context)
+
+                    // Encode the timestamped transcription to binary data


[nitpick] This comment is unnecessary as the code clearly shows JSON encoding. Consider removing this comment as it doesn't add value beyond what the code expresses.

Suggested change

// Encode the timestamped transcription to binary data

Copilot · 2025-09-29T14:32:31Z

Recap/Services/Transcription/TranscriptionService.swift


    private func loadModel(_ modelName: String, isDownloaded: Bool) async throws {
        do {
+            print("Loading WhisperKit model: \(modelName), isDownloaded: \(isDownloaded)")


Using print() statements for logging in production code is not recommended. These should use the logger instance that's already available in the class for consistent logging behavior.

Copilot · 2025-09-29T14:32:31Z

Recap/Services/Transcription/TranscriptionService.swift

                }
            )

+            print("WhisperKit model loaded successfully: \(modelName)")


Using print() statements for logging in production code is not recommended. These should use the logger instance that's already available in the class for consistent logging behavior.

Copilot · 2025-09-29T14:32:31Z

Recap/Services/Transcription/TranscriptionService.swift

-                try await whisperModelRepository.markAsDownloaded(name: modelName, sizeInMB: nil)
+                let modelInfo = await WhisperKit.getModelSizeInfo(for: modelName)
+                try await whisperModelRepository.markAsDownloaded(name: modelName, sizeInMB: Int64(modelInfo.totalSizeMB))
+                print("Model marked as downloaded: \(modelName), size: \(modelInfo.totalSizeMB) MB")


Using print() statements for logging in production code is not recommended. These should use the logger instance that's already available in the class for consistent logging behavior.

Copilot · 2025-09-29T14:32:31Z

Recap/Services/Transcription/TranscriptionService.swift


        } catch {
-            throw TranscriptionError.modelLoadingFailed(error.localizedDescription)
+            print("Failed to load WhisperKit model \(modelName): \(error)")


Using print() statements for logging in production code is not recommended. These should use the logger instance that's already available in the class for consistent logging behavior.

Copilot · 2025-09-29T14:32:32Z

Recap/Audio/Processing/AudioRecordingCoordinator/AudioRecordingCoordinator.swift

+                await MainActor.run {
+                    systemWideTap.activate()
+                }


The systemWideTap.activate() call is redundant here since it's already called earlier in the start() method. This could cause issues or unnecessary work.

Suggested change

await MainActor.run {

systemWideTap.activate()

}

Recap/Audio/Models/AudioProcess.swift

Copilot · 2025-09-29T14:32:33Z

Recap/Recap.entitlements

+	<key>com.apple.security.temporary-exception.audio-unit-host</key>
 	<true/>


Using temporary security exceptions in production should be avoided. This entitlement bypasses sandbox restrictions and may not be acceptable for App Store distribution. Consider implementing proper audio unit hosting within the sandbox.

Suggested change

<key>com.apple.security.temporary-exception.audio-unit-host</key>

<true/>

nilleb · 2025-10-01T13:11:25Z

Closing - Maybe I will re-propose when the project switches to MIT. Sorry for the annoyance.

rawandahmad698 · 2025-10-01T13:27:43Z

Closing - Maybe I will re-propose when the project switches to MIT. Sorry for the annoyance.

The project is MIT Bro. Check it out

nilleb · 2025-10-01T14:53:10Z

I am deeply grateful, Rawa.

But let me rework this a bit because I don't think it's up to quality standards. ^^ (I have learnt a lot about MacOS/Swift during the last week, beyond what my intelligent unanimated friends did for me)

GitWither and others added 13 commits August 6, 2025 14:41

Add a dropdown that shows the transcript in the recording summary

6300891

Implement code review changes, reuse defined color constants

b4d8d8a

Merge remote-tracking branch 'upstream/main' into transcript-dropdown

06ca04a

Merge pull request RecapAI#7 from GitWither/transcript-dropdown

3e3d08a

fix: stuff

d56a4b6

fix: upgrade the project to most recent xcode

0407b38

feat: Add System-Wide audio tap recording functionality

5294134

fix: recording the system audio at last

ac9f5c4

feat: copy transcript and timestamps

1721445

feat: dark theme icon

e563def

feat: cli and gitignore

995c552

fix: tests

3cc24ca

chore: always use the black icon on the system tray

def4b46

rawandahmad698 requested a review from Copilot September 29, 2025 14:28

Copilot AI reviewed Sep 29, 2025

View reviewed changes

nilleb closed this Oct 1, 2025

nilleb reopened this Oct 1, 2025

feat: change the system tray color to red during recording

1ed4753

nilleb force-pushed the feature/copy-transcript branch from 7a7cfe0 to 1ed4753 Compare October 3, 2025 05:13

Ivo Bellin Salarin added 3 commits October 3, 2025 07:16

chore: wipe out commented code as per copilot suggestion

d10547b

fix: restore the original zero-menu behavior

9a104aa

chore: use the system tray tint

c2c945c

		<key>com.apple.security.temporary-exception.audio-unit-host</key>
		<true/>

Conversation

nilleb commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of Change

Testing

Checklist

Screenshots (if applicable)

Additional Notes

Uh oh!

rawandahmad698 commented Sep 29, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

nilleb commented Oct 1, 2025

Uh oh!

rawandahmad698 commented Oct 1, 2025

Uh oh!

nilleb commented Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nilleb commented Sep 25, 2025 •

edited

Loading

nilleb commented Oct 1, 2025 •

edited

Loading