add getters/setters to all Resultset classes and dependencies - issue…#92
Open
pierrelambert wants to merge 3 commits intoRedisGraph:StatisticsImpl_jacksonfrom
Open
add getters/setters to all Resultset classes and dependencies - issue…#92pierrelambert wants to merge 3 commits intoRedisGraph:StatisticsImpl_jacksonfrom
pierrelambert wants to merge 3 commits intoRedisGraph:StatisticsImpl_jacksonfrom
Conversation
Contributor
|
@pierrelambert |
…dencies and test for serialization - issue RedisGraph#89
…dencies and test for serialization - issue RedisGraph#89
DvirDukhan
reviewed
Nov 11, 2020
Comment on lines
+1109
to
+1110
| // Assert.assertTrue((mapper.canSerialize(Statistics.class))); | ||
| // Assert.assertTrue((mapper.canSerialize(Record.class))); |
Comment on lines
+1100
to
+1108
| Assert.assertTrue((mapper.canSerialize(StatisticsImpl.class))); | ||
| Assert.assertTrue((mapper.canSerialize(RecordImpl.class))); | ||
| Assert.assertTrue((mapper.canSerialize(GraphEntity.class))); | ||
| Assert.assertTrue((mapper.canSerialize(ResultSetImpl.class))); | ||
| Assert.assertTrue((mapper.canSerialize(Property.class))); | ||
| Assert.assertTrue((mapper.canSerialize(Node.class))); | ||
| Assert.assertTrue((mapper.canSerialize(Edge.class))); | ||
| Assert.assertTrue((mapper.canSerialize(Path.class))); | ||
| Assert.assertTrue((mapper.canSerialize(ResultSet.class))); |
Contributor
There was a problem hiding this comment.
align indentations, please
|
|
||
| Assert.assertEquals(Arrays.asList("a", "r", "a.name", "a.age", "a.doubleValue", "a.boolValue", "a.nullValue", | ||
| "r.place", "r.since", "r.doubleValue", "r.boolValue", "r.nullValue"), resultSet.getResults().get(0).keys()); | ||
| //Serialization tests |
Contributor
There was a problem hiding this comment.
can you add a scenario of serialization and deserialization?
resultsSet->JSON->resultSet
compare the original resultSet to the generated resultSet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… #89
Added getters and setters / Switch some methods from private to public