Skip to content

Conversation

@henriquemoody
Copy link
Member

Separate handling of invalid formatters from non-scalar values. When a formatter is recognized but the value type is incompatible, pass null to the next modifier instead of the original pipe. This prevents incorrectly suggesting the next modifier should retry with the same formatter.

Added tests using data providers to verify the distinction between pipe not being valid and modifier being unable to modify values.

Assisted-by: OpenCode (GLM-4.7)

Separate handling of invalid formatters from non-scalar values. When a
formatter is recognized but the value type is incompatible, pass null
to the next modifier instead of the original pipe. This prevents
incorrectly suggesting the next modifier should retry with the same
formatter.

Added tests using data providers to verify the distinction between
pipe not being valid and modifier being unable to modify values.

Assisted-by: OpenCode (GLM-4.7)
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.55%. Comparing base (113499a) to head (650269a).

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #19   +/-   ##
=========================================
  Coverage     99.54%   99.55%           
  Complexity      199      199           
=========================================
  Files            29       29           
  Lines           444      446    +2     
=========================================
+ Hits            442      444    +2     
  Misses            2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@henriquemoody henriquemoody merged commit f730ef0 into Respect:main Feb 10, 2026
4 checks passed
@henriquemoody henriquemoody deleted the formatter_modifier branch February 10, 2026 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants