Move FormatterModifier after TransModifier and ListModifier #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Positioning FormatterModifier later in the chain allows TransModifier and ListModifier to handle their specific pipes first. Since FormatterModifier attempts to create a formatter for any pipe it encounters, this change avoids unnecessary formatter creation attempts for known modifiers like `|trans` and `|list`, improving performance. Assisted-by: OpenCode (GLM-4.7)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #20 +/- ##
=========================================
Coverage 99.54% 99.54%
Complexity 199 199
=========================================
Files 29 29
Lines 444 444
=========================================
Hits 442 442
Misses 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Positioning FormatterModifier later in the chain allows TransModifier and ListModifier to handle their specific pipes first. Since FormatterModifier attempts to create a formatter for any pipe it encounters, this change avoids unnecessary formatter creation attempts for known modifiers like
|transand|list, improving performance.Assisted-by: OpenCode (GLM-4.7)