Added @XMLText decorator supporting optional 'required' option#11
Added @XMLText decorator supporting optional 'required' option#11rzacherl wants to merge 1 commit intoRobinBuschmann:masterfrom
Conversation
RobinBuschmann
left a comment
There was a problem hiding this comment.
Looks good so far 👍 Thanks for implementing. I've just added one comment and it would be good to add tests for that :)
| ...options | ||
| }; | ||
|
|
||
| this.prototype.name = key; |
There was a problem hiding this comment.
What's the purpose of this line?
|
I had to find a way to define the value of instance variable |
So, guys, what's about this PR? |
Hi Robin,
please excuse all the unnecessary code changes inside existing files but I wasn't able to find a linter setting which preserved your code.
The code of the newly added XMLText files should be self-explanatory.
Best regards,
Robert