feat(openai-codex): add gpt-5.3-codex-spark model metadata#11620
Merged
hannesrudolph merged 1 commit intoRooCodeInc:mainfrom Feb 20, 2026
Merged
feat(openai-codex): add gpt-5.3-codex-spark model metadata#11620hannesrudolph merged 1 commit intoRooCodeInc:mainfrom
hannesrudolph merged 1 commit intoRooCodeInc:mainfrom
Conversation
hannesrudolph
approved these changes
Feb 20, 2026
Contributor
There was a problem hiding this comment.
PR Review: feat(openai-codex): add gpt-5.3-codex-spark model metadata
Verdict: Sound
This PR does exactly what it says -- adds a single new model entry (gpt-5.3-codex-spark) to the OpenAI Codex provider and covers it with tests. No scope creep detected.
Scope Check
- Files changed: 2 (model definition + test). Perfectly scoped.
- No unrelated rewrites: The only modification to existing code is appending
"gpt-5.3-codex-spark"to theit.eacharray in the test file. - No scope creep: No refactors, no renames, no tangential changes.
Contract Consistency
All fields in the new model entry are valid members of modelInfoSchema (from packages/types/src/model.ts). Verified:
maxTokens,contextWindow,includedTools,excludedTools,supportsImages,supportsPromptCache,supportsReasoningEffort,reasoningEffort,inputPrice,outputPrice,supportsTemperature,description-- all present in the Zod schema.includedTools: ["apply_patch"]andexcludedTools: ["apply_diff", "write_to_file"]are consistent with every other model in the file.inputPrice: 0/outputPrice: 0follows the subscription-based pricing convention.
Intentional Differentiation from Other Models
The Spark variant intentionally differs from other Codex models:
contextWindow: 128000(vs 400000 for others) -- smaller context for a fast model.maxTokens: 8192(vs 128000 for others) -- significantly lower output cap.supportsImages: false(vstruefor others) -- text-only, matching the description.
These differences are internally consistent and align with the "fast, text-only" positioning described in the model description.
Test Coverage
- Added to the parameterized
it.eachtest for valid model IDs. - Dedicated test asserting Spark-specific limits (
contextWindow,maxTokens,supportsImages). - CI passes on all platforms (ubuntu + windows).
Findings
No critical or high-severity issues found.
| Severity | Finding |
|---|---|
| P3 (Low) | Missing // Subscription-based: no per-token costs comment above inputPrice: 0 that most other model entries include. Purely cosmetic -- some entries also omit it (e.g., gpt-5.3-codex, gpt-5.2-codex), so this is consistent with the newer entries. |
| P3 (Low) | No .changeset file included. If this repo requires changesets for releases, one may need to be added before merge. CI does not appear to enforce this for non-bump PRs, so likely fine. |
Summary
Clean, minimal, well-tested addition. Approved.
|
@hannesrudolph could you also approve and merge #11479 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gpt-5.3-codex-sparkto OpenAI Codex model listcontextWindow: 128000,maxTokens: 8192,supportsImages: false)Testing
pnpm vitest run api/providers/__tests__/openai-codex.spec.ts(insrc)pnpm --filter @roo-code/types test -- src/__tests__/provider-settings.test.tsStart a new Roo Code Cloud session on this branch