Merged
Conversation
cc4f4f9 to
d913fd9
Compare
This was referenced Dec 12, 2025
This comment was marked as outdated.
This comment was marked as outdated.
9e4abfb to
b27a0f7
Compare
Collaborator
|
Looks good to me. I can approve but maybe others will have better context? |
642754e to
f7294b5
Compare
This was referenced Dec 23, 2025
eddyb
approved these changes
Dec 24, 2025
f7294b5 to
17596c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see https://github.com/Rust-GPU/cargo-gpu/actions/runs/20230926648 succeeding with "the hack"no longer necessary