Added module name-list-cleaner by hfgd123 · Pull Request #178 · ScootKit/CustomDCBot

hfgd123 · 2026-02-15T22:51:42Z

as per Sukram2.0's suggestion
also added tabs in en.json...

as per Sukram2.0's suggestion also added tabs in en.json...

Copilot

Pull request overview

Adds a new name-list-cleaner module intended to sanitize member display names by stripping leading special characters, and wires it into member update + bot ready events with accompanying English localization strings.

Changes:

Introduces the name-list-cleaner module metadata, configuration schema, and event handlers.
Implements renameMember / checkUsername logic to compute a cleaned nickname (or reset nickname depending on config).
Updates locales/en.json formatting and adds name-list-cleaner locale keys.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
modules/name-list-cleaner/renameMember.js	Core renaming logic and username sanitization helper.
modules/name-list-cleaner/module.json	Module metadata registration (name, author, tags, config examples).
modules/name-list-cleaner/events/guildMemberUpdate.js	Triggers sanitization on nickname/username changes.
modules/name-list-cleaner/events/botReady.js	Sanitizes all cached members on startup.
modules/name-list-cleaner/configs/config.json	Defines configurable behavior (whitelist/blacklist, user whitelist, etc.).
locales/en.json	Adds localized strings for the new module and adjusts indentation in the `ping-protection` section.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

modules/name-list-cleaner/renameMember.js

modules/name-list-cleaner/module.json

modules/name-list-cleaner/renameMember.js

SCDerox · 2026-02-27T11:09:43Z

Hi, quickly checking in, any updates on this?

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

hfgd123 · 2026-02-27T12:11:17Z

Currently working through the suggestions. I didn't get a notification when Copilot answered 😅

- added error handling in case of a nickname reset - fixed empty symbol whitelist - changed handling of names only containing empty characters - changed openSourceURL according to module rename

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

SCDerox · 2026-02-27T12:55:23Z

Sorry, my bad, forgot to comment with the usal comment:

Hi, thanks so much for your contribution.

Also, I have one question for our internal compliance:

Please disclose whether Generative Large Language Models ("Generative AI", e.g. Coplilot) were used and to what extent to write this code. In addition, please confirm that you have reviewed and tested any generated code thoroughly. For details, please review our AI Policy.
This branch has conflicts. Please ensure that no conflicts exist with the beta-discordjs14 branch.

hfgd123 · 2026-02-27T12:59:31Z

No problem.

About the LLM thing: Yes, GitHub Copilot was used (for completion of sigular lines and for writing some of the Strings that are shown to users). I didn't check the AI code specifically, but I tested the module as a whole.

I can try to find out how to resolve the conflicts

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-27T14:48:00Z

modules/name-list-cleaner/renameMember.js

+renameMember = async function (client, guildMember) {
+    let newName;


renameMember is assigned without const/let/function declaration, which creates an implicit global variable in non-strict mode and can lead to hard-to-debug collisions. Declare it explicitly (e.g., const renameMember = … or async function renameMember(…)).

Copilot · 2026-02-27T14:48:00Z

modules/name-list-cleaner/renameMember.js

+        if (name.charAt(0).match(/^[a-zA-Z0-9]$/)) {
+            return name;
+        } else {
+            return await checkUsername(client, name.substring(1), isUsername);
+        }
+    } else if (!moduleConf.symbolWhitelist.includes(name.charAt(0)) && !moduleConf.isBlacklist) {
+        if (name.charAt(0).match(/^[a-zA-Z0-9]$/)) {


checkUsername treats only ASCII [a-zA-Z0-9] as alphanumeric. This will strip leading non-ASCII letters/digits (e.g., ü/ß/Ж/漢/١) even though they are valid characters in Discord names, causing unexpected renames. Consider using a Unicode-aware check (e.g., Unicode property escapes) or clarify the intended restriction.

Suggested change

if (name.charAt(0).match(/^[a-zA-Z0-9]$/)) {

return name;

} else {

return await checkUsername(client, name.substring(1), isUsername);

}

} else if (!moduleConf.symbolWhitelist.includes(name.charAt(0)) && !moduleConf.isBlacklist) {

if (name.charAt(0).match(/^[a-zA-Z0-9]$/)) {

if (name.charAt(0).match(/^[\p{L}\p{N}]$/u)) {

return name;

} else {

return await checkUsername(client, name.substring(1), isUsername);

}

} else if (!moduleConf.symbolWhitelist.includes(name.charAt(0)) && !moduleConf.isBlacklist) {

if (name.charAt(0).match(/^[\p{L}\p{N}]$/u)) {

If you want it to accept anything else, you can whitelist it, ig

imagine whitelisting every chinese character

true... But at the same time: Where would you draw the line

Copilot · 2026-02-27T14:48:00Z

modules/name-list-cleaner/events/guildMemberUpdate.js

+
+    if (!client.botReadyAt) return;
+    if (newGuildMember.guild.id !== client.guild.id) return;
+    if (oldGuildMember.nickname === newGuildMember.nickname && oldGuildMember.user.username === newGuildMember.user.username) return;


guildMemberUpdate generally won’t fire for global username changes (those emit userUpdate), so the oldGuildMember.user.username !== newGuildMember.user.username check is unlikely to catch username edits. If alsoCheckUsernames is meant to react to username changes, add a userUpdate event handler (and map the updated user to the guild member) instead of relying on guildMemberUpdate.

Suggested change

if (oldGuildMember.nickname === newGuildMember.nickname && oldGuildMember.user.username === newGuildMember.user.username) return;

if (oldGuildMember.nickname === newGuildMember.nickname) return;

locales/en.json

Copilot · 2026-02-27T14:48:01Z

modules/name-list-cleaner/renameMember.js

+    if (moduleConf.symbolWhitelist.length === 0) {
+        if (name.charAt(0).match(/^[a-zA-Z0-9]$/)) {
+            return name;
+        } else {
+            return await checkUsername(client, name.substring(1), isUsername);
+        }


checkUsername uses charAt(0) and substring(1), which operate on UTF-16 code units. This breaks the notion of “first character” for surrogate pairs / emoji (and makes it impossible to whitelist an emoji reliably). Consider iterating by Unicode code points/graphemes (e.g., [...name][0] / slicing by code points, or Intl.Segmenter if you need grapheme clusters).

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Added module name-list-cleaner

81e26b6

as per Sukram2.0's suggestion also added tabs in en.json...

SCDerox requested a review from Copilot February 17, 2026 18:56

Copilot started reviewing on behalf of SCDerox February 17, 2026 18:56 View session

Copilot AI reviewed Feb 17, 2026

View reviewed changes

Update modules/name-list-cleaner/renameMember.js

cd38e3a

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

hfgd123 and others added 3 commits February 27, 2026 13:26

Implemented suggested changes

208be14

- added error handling in case of a nickname reset - fixed empty symbol whitelist - changed handling of names only containing empty characters - changed openSourceURL according to module rename

Update modules/name-list-cleaner/renameMember.js

1933727

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update modules/name-list-cleaner/renameMember.js

92664c6

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Merge branch 'beta-discordjs14' into beta-discordjs14

fee61fa

hfgd123 requested a review from Copilot February 27, 2026 14:41

Copilot started reviewing on behalf of hfgd123 February 27, 2026 14:42 View session

Copilot AI reviewed Feb 27, 2026

View reviewed changes

Update locales/en.json

5c0b6ea

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

		renameMember = async function (client, guildMember) {
		let newName;

	if (oldGuildMember.nickname === newGuildMember.nickname && oldGuildMember.user.username === newGuildMember.user.username) return;
	if (oldGuildMember.nickname === newGuildMember.nickname) return;

Uh oh!

Conversation

hfgd123 commented Feb 15, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SCDerox commented Feb 27, 2026

Uh oh!

hfgd123 commented Feb 27, 2026

Uh oh!

SCDerox commented Feb 27, 2026

Uh oh!

hfgd123 commented Feb 27, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

hfgd123 Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

SCDerox Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

hfgd123 Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants