Added Mish activation function - Ready for merge#94
Open
JamesLear92 wants to merge 4 commits intoSergio0694:masterfrom
Open
Added Mish activation function - Ready for merge#94JamesLear92 wants to merge 4 commits intoSergio0694:masterfrom
JamesLear92 wants to merge 4 commits intoSergio0694:masterfrom
Conversation
Math.Pow is not supported, so method has been rewritten to avoid it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added the Mish activatation function as suggested in #93
This is work in progress at the moment as it's working perfectly when not using CUDA.When running the DigitsCudaTest sample with the Mish function, I'm currently seeing:MishPrime function looks right to me (and works fine without cuda), but evidently something is wrong. I wonder if this is something Alea need to support.EDIT:
Now working, and ready for merge.
Issue was caused by MishPrime function using Math.Pow (unsupported).